Expose race-id as command line parameter #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we expose the race id as command line parameter. As the internal name "trial id" and the related name "trial timestamp" are inconsistent with this terminology we rename them to "race id" and "race timestamp" respectively and add a backwards-compatibility layer that will be removed again in elastic#777.
danielmitterdorfer
added
enhancement
ebadyano
reviewed
Sep 30, 2019
| @@ -42,6 +42,18 @@ | |||
| } | |||
| } | |||
| }, | |||
| "race-id": { | |||
There was a problem hiding this comment.
Just to confirm, are we keeping trial-id and trial-timestamp sections above for backwards compatibility?
There was a problem hiding this comment.
Correct. This will be removed with #777.
|
Thanks for the review! |
novosibman
pushed a commit
to novosibman/rally
that referenced
this pull request
Oct 2, 2019
With this commit we expose the race id as command line parameter. As the internal name "trial id" and the related name "trial timestamp" are inconsistent with this terminology we rename them to "race id" and "race timestamp" respectively and add a backwards-compatibility layer that will be removed again in elastic#777. Relates elastic#778
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we expose the race id as command line parameter. As the
internal name "trial id" and the related name "trial timestamp" are
inconsistent with this terminology we rename them to "race id" and "race
timestamp" respectively and add a backwards-compatibility layer that
will be removed again in #777.