Calculate system metrics per node #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we switch to a sum aggregation in the I/O charts as metrics are now stored per node instead of per cluster. For correct results across the whole cluster we thus need to sum up all values from individual nodes.
danielmitterdorfer
added
enhancement
7 tasks
dliappis
approved these changes
Nov 11, 2019
docs/migrate.rst
Outdated
| @@ -4,6 +4,11 @@ Migration Guide | |||
| Migrating to Rally 1.4.0 | |||
| ------------------------ | |||
|
|
|||
| Index size and Total Written are not contained in the command line report | |||
There was a problem hiding this comment.
Thanks. I'll change this accordingly before merging.
esrally/metrics.py
Outdated
| pass | ||
|
|
||
|
|
||
| # helper function for encoding and decoding float keys so that the Elasticsearch metrics store can safe it. |
There was a problem hiding this comment.
typo: safe it -> save them
There was a problem hiding this comment.
Thanks. I'll change this accordingly before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we split aggregation of "global" results (which can be
determined by inspecting the cluster remotely) and results based on system
metrics (which can only be determined per Elasticsearch node on that respective
machine). This will help us to provide specific subcommands that can manage an
Elasticsearch node but are still able to retrieve system metrics and send it to
the metrics store.
Relates #697
Closes #792