Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logrotate comments to separate lines #821

Merged

Conversation

dliappis
Copy link
Contributor

because logrotate doesn't support in-line comments.

Relates #818

because logrotate doesn't support in-line comments.
@dliappis dliappis added the :Docs Changes to the documentation label Nov 19, 2019
@dliappis dliappis added this to the 1.4.0 milestone Nov 19, 2019
@danielmitterdorfer danielmitterdorfer added the enhancement Improves the status quo label Nov 19, 2019
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@dliappis
Copy link
Contributor Author

Will go ahead and merge now as #818 depends on it, thanks all for the reviews.

@dliappis dliappis merged commit 12a5b34 into elastic:master Nov 19, 2019
@dliappis dliappis deleted the logrotate-comments-in-separate-lines branch November 19, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Docs Changes to the documentation enhancement Improves the status quo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants