Store units in results #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we store units for all operation-related samples and system metrics also for summary metrics.
danielmitterdorfer
added
enhancement
hub-cap
approved these changes
Mar 26, 2020
| @@ -732,16 +732,17 @@ def get_raw(self, name, task=None, operation_type=None, sample_type=None, node_n | |||
| """ | |||
| return self._get(name, task, operation_type, sample_type, node_name, mapper) | |||
|
|
|||
| def get_unit(self, name, task=None): | |||
| def get_unit(self, name, task=None, node_name=None): | |||
There was a problem hiding this comment.
I dont see this used in the PR, was it just added in case we need to use it?
There was a problem hiding this comment.
Good catch! I added it in 11364ad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we store units for all operation-related samples and
system metrics also for summary metrics.