Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate more integration tests #966

Merged
merged 3 commits into from
Apr 20, 2020

Conversation

danielmitterdorfer
Copy link
Member

With this commit we migrate a few more integration tests from the shell script approach to the new approach based on py.test.

@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Apr 16, 2020
@danielmitterdorfer danielmitterdorfer added this to the 1.5.0 milestone Apr 16, 2020
@danielmitterdorfer danielmitterdorfer self-assigned this Apr 16, 2020
Copy link
Contributor

@hub-cap hub-cap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! one thing i would be fine with is using single quotes in those esrally invocation lines to protect us against any bash substitution. I assume they are all regular strings tho.

Example

"esrally \"$(some foo junk)\" "

vs

"esrally '$(some foo junk)' "

will be evalutated differently on the command line

@@ -27,6 +27,8 @@
from esrally.utils import process, io

CONFIG_NAMES = ["in-memory-it", "es-it"]
DISTRIBUTIONS = ["2.4.6", "5.6.16", "6.8.0", "7.1.1"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this something that should be in the .ci folder for externalization, vs in some python code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should put this in .ci as nothing except our integration test code is using this.

@danielmitterdorfer danielmitterdorfer merged commit 6721301 into elastic:master Apr 20, 2020
@danielmitterdorfer danielmitterdorfer deleted the migrate-it branch April 20, 2020 06:43
@danielmitterdorfer
Copy link
Member Author

Thanks for your review!

one thing i would be fine with is using single quotes in those esrally invocation lines to protect us against any bash substitution.

I think we can address this separately but that's a good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants