Cache source artifacts #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add a cache for source artifacts. It can be enabled by setting `cache = true` in the `source` section of `rally.ini`. Caching works based on the specified revision. We don't implement an eviction policy for now but assume that an external process cleans up cached artifacts.
danielmitterdorfer
added
enhancement
dliappis
reviewed
May 11, 2020
esrally/mechanic/supplier.py
Outdated
| # this can be None if the Elasticsearch does not reside in a git repo and the user has only | ||
| # copied all source files. In that case, we cannot resolve a revision hash and thus we cannot cache. | ||
| if self.cached_path: | ||
| shutil.copy(original_path, self.cached_path) |
There was a problem hiding this comment.
What if there is some issue, out of disk space, file in use etc? Should we catch IOError, log it, and fallback to no caching?
There was a problem hiding this comment.
Thanks! I've pushed 937595e.
danielmitterdorfer
added a commit
to danielmitterdorfer/rally
that referenced
this pull request
May 13, 2020
With this commit we create the artifact cache directory if it does not exist yet. Otherwise, the artifact cannot be cached making the cache ineffective. Relates elastic#992
danielmitterdorfer
added a commit
that referenced
this pull request
May 13, 2020
With this commit we create the artifact cache directory if it does not exist yet. Otherwise, the artifact cannot be cached making the cache ineffective. Relates #992
danielmitterdorfer
added a commit
to danielmitterdorfer/rally
that referenced
this pull request
May 20, 2020
With this commit we add the artifact cache introduced by elastic#992 also for plugins and implement a cache cleanup mechanism that cleans up artifacts after seven days by default (can be configured with `cache.days`). As artifact caching can now replace the pipeline `from-sources-skip-build` we deprecate it along with `from-sources-complete` and introduce a new pipeline `from-sources` instead.
danielmitterdorfer
added a commit
that referenced
this pull request
May 25, 2020
With this commit we add the artifact cache introduced by #992 also for plugins and implement a cache cleanup mechanism that cleans up artifacts after seven days by default (can be configured with `cache.days`). As artifact caching can now replace the pipeline `from-sources-skip-build` we deprecate it along with `from-sources-complete` and introduce a new pipeline `from-sources` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add a cache for source artifacts. It can be enabled
by setting
cache = truein thesourcesection ofrally.ini.Caching works based on the specified revision. We don't implement an
eviction policy for now but assume that an external process cleans up
cached artifacts.