Quick Work around to remove stuck messages #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
approved these changes
Mar 16, 2021
| actionPermissions: ActionPermissions, | ||
| messageContent: MessageContent?, | ||
| msgType: String?) { | ||
| if (timelineEvent.root.sendState == SendState.SENT) { |
There was a problem hiding this comment.
This test is already done before calling this method, so we could remove it
There was a problem hiding this comment.
Root cause is complex and hard to catch on synapse side, two main scenario could cause that:
- It could be the downstream bug (Missing event down /sync for some devices, but not others matrix-org/synapse#9624)
- Or a gappy sync scenario (two much events, and the synced event is in the gap, and in this case clients should have some mechanism to backfill if a sent event is not synced after following sync...)
Never mind, I did not see the link to Synapse issues. Thanks |
|
(Please fix the warning in the code) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick work around to remove stuck messages at the bottom of timeline.
Currently only choice is to clear cache and do a full initial sync.
This PR is just adding an option to cancel sent but not synced message, only effect is that it will delete the local echo.
This does not fix the root issues, See:
#516
matrix-org/synapse#9424
matrix-org/synapse#9624