ICE failures on v0.2.7/0.2.8 #553
Assignees
Labels
O-Frequent
Affects or can be seen by most users regularly or impacts most users' first experience
S-Major
Severely degrades major functionality or product features, with no satisfactory workaround
T-Defect
Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems
Comments
dbkr
added
T-Defect
dbkr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this issue
Aug 25, 2022
We were casting a POJO to an RTCIceCandidate for the dummy end-of-candidates candidate, but #2473 started calling .toJSON() on these objects. Store separately whether we've seen the end of candidates rather than adding on a dummy candidate object. A test for this will follow, but a) I want to get this fix out and b) I'm currently rewriting the call test file to add typing. Fixes element-hq/element-call#553
3 tasks
dbkr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this issue
Aug 26, 2022
* Fix ICE end-of-candidates messages We were casting a POJO to an RTCIceCandidate for the dummy end-of-candidates candidate, but #2473 started calling .toJSON() on these objects. Store separately whether we've seen the end of candidates rather than adding on a dummy candidate object. A test for this will follow, but a) I want to get this fix out and b) I'm currently rewriting the call test file to add typing. Fixes element-hq/element-call#553 * Remove hacks for testing * Switch if branches
|
Fixed by matrix-org/matrix-js-sdk#2622 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
We're getting reports of fairly consistent "other people appearing as grey squares". Looking at the logs, this appears to be due to ICE failures.
Outcome
What did you expect?
What happened instead?
Operating system
No response
Browser information
No response
URL for webapp
No response
Will you send logs?
No
The text was updated successfully, but these errors were encountered: