Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give user feedback if the rageshake submission failed #2621

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

hughns
Copy link
Member

@hughns hughns commented Sep 11, 2024

Otherwise it silently swallows errors like 50x.

The design isn't nice and the user might need to scroll to see the whole message.

image

n.b. the screenshot doesn't show the wording but does show the revised location of the error message.

Otherwise it swallows errors like 50x
Copy link
Contributor

@fkwp fkwp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hughns hughns merged commit a5aeb6f into livekit Sep 11, 2024
6 checks passed
@hughns hughns deleted the hughns/rageshake-error-handling branch September 11, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants