Read receipts are falling from the sky once again #27916
Labels
A-Read-Receipts
O-Occasional
Affects or can be seen by some users regularly or most users rarely
S-Minor
Impairs non-critical functionality or suitable workarounds exist
T-Defect
X-Regression
Comments
|
Looks like a regression #26798 |
|
Unfortunately can't send logs because of |
dosubot
bot
added
A-Read-Receipts
O-Occasional
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this issue
Aug 23, 2024
The way it was done involved remembering dom nodes and then getting their position later when animating the receipt to its next position, but I'm not sure how this worked since the DOM node may not neccessarily be in the DOM anymore. Instead, just remember the bounding box coordinates. At worst it might go weird if the window is resized but seems fine in practice. Also, keeping references to dom nodes feels like a fast road to memory leaks. Fixes element-hq/element-web#27916
4 tasks
github-merge-queue bot
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this issue
Sep 3, 2024
* Fix read receipt animation The way it was done involved remembering dom nodes and then getting their position later when animating the receipt to its next position, but I'm not sure how this worked since the DOM node may not neccessarily be in the DOM anymore. Instead, just remember the bounding box coordinates. At worst it might go weird if the window is resized but seems fine in practice. Also, keeping references to dom nodes feels like a fast road to memory leaks. Fixes element-hq/element-web#27916 * Attempt to write a test for read receipts and fix naming * Another test also change a condition to make it testable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
Outcome
What did you expect?
Read receipt of the other user moves from last position to next read position
What happened instead?
Read receipts fall from the sky
Operating system
NixOS 24.05
Browser information
Firefox 128.0.3
URL for webapp
https://develop.element.io/
Application version
Version von Element: 43fa2e5-react-ad8da8307964-js-78cbf7cd28f7 Krypto-Version: Rust SDK 0.7.1 (c8c9d15), Vodozemac 0.6.0
Homeserver
several
Will you send logs?
No (because of
: 'logs' is not a known object store name)The text was updated successfully, but these errors were encountered: