Superfluous space inserted when entering a '

[rhaamo]

Description

When entering a ' there is a space inserted right before in the input prompt.

Steps to reproduce

• In a chat
• Type like that's
• Expect to see that's
• See that 's instead
  

Version information

• Platform: web (in-browser)
• Browser: Firefox Nightly (63.0a1, no stable to test)
• OS: Ubuntu
• URL: my own deployment of riot, reproduced with v0.16.0 and v0.16.1-rc.1

Markdown enabled or no doesn't change anything.
My layout is "English (US, intl., with dead keys)"
I used the firefox Profile Manager to create a blank one, logged to my riot, still have the issue.

[lampholder]

There are a couple of other dead keys related bugs:

• Dead keys stopped working in the desktop version #7124
• Making quotes or apostrophes with deadkeys doesn't work #7149

My problem is I don't know enough about this keyboard layout to reproduce the problems.

So, to try and create the right test environment, here's what I'm doing:

• On Ubuntu LTS 16.04
• Terminal: $ sudo dpkg-reconfigure keyboard-configuration
• Choose: Generic 105-key (Intl) P
• Choose: English (US)
• Choose: English (US) - English (US, international with dead keys)
• Choose key to function as AltGr: The default for the keyboard layout
• Choose compose key: No compose key
• Choose contral+alt+backspace to terminate X server: No

Then:

• Go to riot electron
• Select composer
• Type that's by pressing the keys: thatAltGr+'s
• Pressing carriage return to submit the message to riot

When I do this, I see that's exactly as it's meant to be seen - no additional spaces.

So - what's different between my test setup and what you're doing? If you can highlight the differences then we can get a reproducable problem and figure out what needs doing for a fix :D

Thanks!

[rhaamo]

Everything is same here, I just don't use the electron but web app.

However I type my ' by pressing ' then space, using AltGr' it works, just not the other method.

Same issue with ` too.

[rien]

I am also having this issue. When trying to insert a ' or " using the ' + space method. This is how dead keys work.

Usually, the diacritic itself can be generated as an isolated character by pressing the dead key followed by space; so a plain grave accent can be typed by pressing ` and then Space. This legacy behavior is newly replaced with a more efficient one with respect to the use of combining diacritics following the Unicode Standard. The combining diacritic is then obtained with Space, while a spacing form of the diacritic is inserted with No-Break Space (typically ⇧ Shift+Space or AltGr+Space).

[turt2live]

@rhaamo have you seen this on recent versions of Riot (0.17 or higher)? I'm a little concerned it is a duplicate of #7124 however #7124 says that it doesn't happen on Firefox.

[rhaamo]

I definitely had this issue on Firefox and was the case with 0.17.0 too.

However in the mean time I upgraded from Ubuntu LTS to the latest "stable" and I can't reproduce the issue (still sometimes the '" etc. acts weirdly).

So... I don't really know, that issue have been affecting a bunch of people and some works where some other using the same setup doesn't.

Perhaps something on gnome/gtk input handling side was broken and updating fixed it.

I might get back to LTS because the "stable" is causing me issues (unrelated to riot) so I will look if it's again an issue after reinstalling.

[turt2live]

I'll give it a try on 18.04 and see what happens. My testing with 18.10 seems to show it is fixed, so it might indeed be a package problem.

[turt2live]

I think this might be an 18.04 issue at the very least: I can't get the dead keys to work in any application. In 18.10 everything is fine, but in 18.04 is definitely broken. I tried with US International (with dead keys) and Spanish (with dead tilde).

[turt2live]

This is not an upstream issue as far as I can tell. I finally got a reproducible test case, and it is specific to Riot.

[turt2live]

I'm pretty sure this is an upstream Firefox issue. Firefox is sending two keyDown events for space, leading to Riot doing the right thing and inserting two spaces. I've reported it here and I guess we'll see where it goes: https://bugzilla.mozilla.org/show_bug.cgi?id=1505147

I managed to create a minimal test case to prove it is not a Riot issue with this code pen: https://codepen.io/anon/pen/YRyNpv

[rhaamo]

Thanks for finding this !

I tried your codepen but can't reproduce, but I'm using Firefox Nightly (65.0a1 (2018-10-30) currently) on ubuntu 18.10 too.

That's a weird one, let's see how the firefox side of the bug will goes.

[turt2live]

As of a few minutes ago, the Firefox bug was classified as fixed for Firefox 65. Would be good to see if the issue gets fixed for people when the patch lands somewhere usable for testing.

[jryans]

The Firefox fix here should be present in both Nightly and Beta builds, if someone affected would like to give those a try to confirm the fix. It hasn't reached Release channel yet.

[rhaamo]

I've finally reinstalled ubuntu lts after too many issues with my update to the latest and I can try again.

Updated riot (web) to 0.17.8 and firefox is nightly up to date.

And I still have the superfluous spaces in riot :(

[jryans]

I have just compared Firefox 64 vs. 66 on Ubuntu 18.04.1.

It appears there are multiple Firefox bugs in play here:

• @turt2live reported the case of ''Space which I have verified is indeed fixed in Firefox 65+
• I have reported the case of 'Space which is currently waiting on Firefox for triage

[rhaamo]

from the reply in the new firefox bug issue, it looks like it's the correct behaviour and not a bug (in firefox).

so it would be a bug in the input lib-thing riot-web is using ?

[jryans]

For the 'Space case, it does seem like Firefox is following the keyboard events spec more closely than Chrome, so it's unlikely that Firefox will make a change.

After more investigation, the Slate input library we use in Riot does not have this issue by itself. Using the Slate example page, 'Space works as expected (a single ' character is added).

The problem is introduced by an onKeyDown handler in the Riot React SDK. This exists to mark each word you type as separate chunks for undo / redo.

One way to keep this undo feature while also avoiding the extra space problem here would be to instead use the keypress event in place of keydown. However... the Slate library doesn't currently let you use onKeyPress handlers. 😭 So, for now I am trying to investigate if Slate would accept an addition of onKeyPress handlers.

There may also be some other way to rewrite what Riot's doing with the space character that also avoids this issue, so we'll keep looking at other possibilities as well.

Thanks for your patience. I can imagine this must be frustrating!

[t3chguy]

Is this still an issue for you in the new composer?

[t3chguy]

Assuming no