Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to warn about missing support files #358

Closed
wants to merge 1 commit into from
Closed

Update README to warn about missing support files #358

wants to merge 1 commit into from

Conversation

WasabiFan
Copy link

eliben
eliben requested changes Dec 9, 2019
View reviewed changes
Copy link
Owner

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think mentioning it in a single place is sufficient. Also these files are definitely in the PyPI tarball, but pip/setup do not install them.

@WasabiFan
Copy link
Author

I'll let you pick which place you'd prefer (you can edit this PR from the web interface). I think the fact they're included in the tarball doesn't really matter because it won't get installed. As long as this is clarified so people don't waste time on it, I'm happy.

@eliben eliben closed this in 74cc649 Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliben eliben eliben requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WasabiFan @eliben