Update c_parser.py to fix string concatenation error #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not remove consecutive double quotes, as it might result in a different string in case of an escaped octal or hexadecimal value at the end of the first string AND a numeric character at the beginning of the second string
eliben
reviewed
Jul 3, 2024
| @@ -1674,7 +1674,7 @@ def test_unified_string_literals(self): | |||
| self.assertEqual(d1, ['Constant', 'string', '"hello"']) | |||
|
|
|||
| d2 = self.get_decl_init('char* s = "hello" " world";') | |||
| self.assertEqual(d2, ['Constant', 'string', '"hello world"']) | |||
| self.assertEqual(d2, ['Constant', 'string', '"hello"" world"']) | |||
There was a problem hiding this comment.
Unfortunately, this makes no sense in the general case - it goes against language semantics (see the discussion on the issue)
There was a problem hiding this comment.
Sadly the general case is wrong in particular cases and cannot be extended to cover these. And keeping the double quotes only when required would be way too complicated (would need to check if the last character of the first string is an escaped hexa/octal character that might wrongly merge with the first character of the second string)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not remove consecutive double quotes, as it might result in a different string in case of an escaped octal or hexadecimal value at the end of the first string AND a numeric character at the beginning of the second string
e.g.
"\07""7"must not be merged in"\077"