Ena mars receipt #38
Merged
Ena mars receipt #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdp-cloud
approved these changes
Jun 20, 2024
apriltuesday
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Looks good to me! To confirm what we discussed in the meeting, yes the info "name" and error "path" can be optional.
It also will be good in subsequent PRs to start implementing the receipts for other ENA error cases, like the "data file not found situation" and any others - maybe can sit down with @dipayan1985 at some future date and get some examples.
.../main/java/com/elixir/biohackaton/ISAToSRA/controller/WebinIsaToXmlSubmissionController.java
Show resolved
Hide resolved
|
This is great! |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting ENA receipt to MARS receipt: