[#184] gracefully handles server process shutdown #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beligante
force-pushed
the
gracefully-handle-server-process-shutdown
branch
from
dc02197
to
5883c4a
Compare
beligante
commented
Jul 1, 2024
sleipnir
approved these changes
Jul 2, 2024
| @@ -7,6 +7,12 @@ defmodule GRPC.Integration.ServerTest do | |||
| def get_feature(point, _stream) do | |||
| %Routeguide.Feature{location: point, name: "#{point.latitude},#{point.longitude}"} | |||
| end | |||
|
|
|||
| def route_chat(_ex_stream, stream) do | |||
| GRPC.Server.send_headers(stream, %{}) | |||
There was a problem hiding this comment.
Hi, I'm investigating a Cowboy shutdown issue for my gRPC service running version v0.9.0 in production. My client receives {:error, %GRPC.RPCError{status: 13, message: "status got is 204 instead of 200"}} when Cowboy shuts down.
In my unit test, if I add this line GRPC.Server.send_headers(stream, %{}), my client receives {:error, %GRPC.RPCError{status: 13, message: ":stream_error: {:stream_error, :no_error, :\"Stream reset by server.\"}"}}.
How can I gracefully handle the service's endpoint shutdown from the client side? Should I send headers like retry or goaway to prompt the client to retry?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #184
Add pattern match to handle server process shutdown. It's very common to see these error happen when we manually setup gRPC server in our test cases. ExUnit gracefully shutdown the applications (for example), thus causing the server processes to exit with
:shutdownreason.Without this handler, a lot of error logs are produced, causing to misleading logs.