Add option to decide what to do on invalid UTF-8 urlencoded params #1159 #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and decode_done/2 instead.
…ks/plug into plug_builder_documentation_edits
* added :validate_utf8_error option to plug/lib/plug/parsers/urlencoded.ex * added :validate_utf8_error option to plug/lib/plug/parsers/multipart.ex * refactored Plug.Conn.Utils.validate_utf8! to return binary or exception * added :validate_utf8_error option to plug/lib/plug/parsers.ex * added :validate_utf8_error to plug/lib/plug/conn/query.ex * refactored plug/lib/plug/conn/query.ex to remove rescue, and remove "if" conditional * refactored Plug.BadResponseError to support different client request errors * refactored Plug BadRequestError / added Plug.BadResponseError to support status codes and messages * Plug.Conn.Utils.validate_utf8! support for any status code * Plug.Conn.Utils.validate_utf8! keeps binary value in state * minor edits to Plug.Conn
bradhanks
force-pushed
the
utf8_error
branch
from
07a4a64
to
dc38b3d
Compare
|
Hi @bradhanks ! The change should be smaller than here. Inside the |
|
Sorry I did not mean to close this. I have it done I think. I'm just writing some tests. |
|
Created new PR #1200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the ability to set any status code when utf8 validation fails. It's somewhat related to the issue #1159.
I'm expecting that nothing will be useable as is, but I'm happy to make edits.
What I lack in exp, I make up in enthusiasm?