Add Plug.Adapters.Test.Conn tests #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Plug.Adapters.Test.Conn.conn/4 test cases for params that have a struct or function value. * Add test that asserts Plug.Adapters.Test.Conn.conn/4 writes a message to stderr when the URI path does not start with forward slash. * Add test that asserts Plug.Adapters.Test.Conn.push/3 sends message including path and headers.
|
I haven't included the following test. +++ b/test/plug/adapters/test/conn_test.exs
@@ -7,6 +7,7 @@ defmodule Plug.Adapters.Test.ConnTest do
conn = conn(:get, "/", "abcdefghij")
{adapter, state} = conn.adapter
+ assert {:ok, "abcdefghij", _state} = adapter.read_req_body(state)A binary larger than the default length would make for a better test, but that would be a very large binary. |
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Plug.Adapters.Test.Conn.conn/4 test cases for params that have a struct or function value.
Add test that asserts Plug.Adapters.Test.Conn.conn/4 writes a message to stderr when the URI path does not start with forward slash.
Add test that asserts Plug.Adapters.Test.Conn.push/3 sends message including path and headers.