Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completions #1029

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Completions #1029

merged 2 commits into from
Feb 20, 2024

Conversation

Rayzeq
Copy link
Contributor

@Rayzeq Rayzeq commented Feb 19, 2024

This PR makes it so that the shell-completions subcommand is handled before anything else.
This is useful in NixOS when generating shell completions in the build of a derivation. Without this PR, it fails with this error:

 2024-02-19T19:37:36.923Z ERROR eww::error_handling_ctx > Failed to initialize eww paths

Caused by:
    Configuration directory /homeless-shelter/.config/eww does not exist

Checklist

  • I added my changes to CHANGELOG.md, if appropriate.
  • I used cargo fmt to automatically format all code before committing

@classabbyamp
Copy link

can confirm this issue exists in void linux's packaging system and this patch fixes it

@classabbyamp classabbyamp mentioned this pull request Feb 20, 2024
Merged
@elkowar elkowar merged commit d96586c into elkowar:master Feb 20, 2024
1 check passed
@Rayzeq Rayzeq deleted the completions branch February 20, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rayzeq @classabbyamp @elkowar