Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "what's new" tile to launcher #2857

Merged
merged 11 commits into from
Aug 15, 2022
Merged

Conversation

salonee13
Copy link
Contributor

@salonee13 salonee13 commented Jul 26, 2022

Fixes #2795

What changes were proposed in this pull request?

Added a tile in launcher called 'What's new'. It is connected to a link that takes you to the releases page and shows you the latest version of Elyra you have installed.

How was this pull request tested?

I ran make watch and then opened another terminal and ran jupyterlab --watch and was able to edit and view the changes to the launcher to check and see if the tile was there and worked by opening the correct link.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Jul 26, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@kiersten-stokes kiersten-stokes added this to the 3.11.0 milestone Jul 26, 2022
Copy link
Member

@karlaspuldaro karlaspuldaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @salonee13 , code and functionality look great!
I tested locally and I can see the new launcher card:
image

It would be helpful to also add a small integration test to make sure the card is always visible.
This would be done in this test file and you can use the documentation card test as example. It would look like

cy.get('.jp-LauncherCard[data-category="Elyra"][title="What\'s new"]:visible');

@marthacryan
Copy link
Member

This looks great, thanks for the contribution!

One suggestion I have is that I think it'd be better if the icon was more specific to releases.

Let me know if you need any help with that!

@ptitzler ptitzler changed the title new launcher tile Add "what's new" tile to launcher Jul 28, 2022
@shadowluigi27
Copy link
Contributor

shadowluigi27 commented Aug 5, 2022

hi, I would like to be assigned to this PR, I would like to add the requested changes

@akchinSTC
Copy link
Member

@salonee13 - can you add @shadowluigi27 to your list of collaborators like we did for cherry?

@salonee13
Copy link
Contributor Author

salonee13 commented Aug 8, 2022 via email

@akchinSTC
Copy link
Member

@salonee13 - awesome! thanks!
@shadowluigi27 - you should be able to push your changes now

@ptitzler ptitzler added the kind:enhancement New feature or request label Aug 9, 2022
@ptitzler
Copy link
Member

ptitzler commented Aug 9, 2022

Remember to also update the release script as indicated in this comment. As is the link would always open to the 'latest' release, which isn't necessarily the release the user has installed.

Copy link
Member

@karlaspuldaro karlaspuldaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the review comments! This looks great, I only have a small suggestion to fix on the icon styling.

packages/ui-components/style/icons/whats-new.svg Outdated Show resolved Hide resolved
@akchinSTC
Copy link
Member

Tile displays version now as well and release script changes are in
image

create-release.py Outdated Show resolved Hide resolved
create-release.py Outdated Show resolved Hide resolved
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See earlier comments.

@ptitzler
Copy link
Member

The tool tip display seems to randomly switch back and forth between displaying the internal label and the caption ...

2022-08-11_19-07-16 (1)

I'm seeing this behavior pretty consistently. It doesn't seem to happen for other tiles

@akchinSTC
Copy link
Member

Test failure and tooltip issue have been resolved. Thx @karlaspuldaro

Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akchinSTC akchinSTC merged commit 7a55b67 into elyra-ai:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display what's new link after a new version of Elyra was installed
7 participants