Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warning for local runtime type #2862

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

kiersten-stokes
Copy link
Member

@kiersten-stokes kiersten-stokes commented Jul 28, 2022

Fixes #2855

What changes were proposed in this pull request?

Based on some discussion related to #2855, we decided to consider lowercase local equivalent to uppercase LOCAL when checking against runtime types. This PR suppresses the warning message about using (eventually) deprecated runtime type names (kfp, airflow) for the local runtime only. This is the 'path of least resistance' for this issue. If we ever fully remove the ability to query with the lowercase local, we'll probably want the frontend to adjust its API call to use the LOCAL RuntimeProcessorType Enum member.

How was this pull request tested?

Queried the elyra/pipeline/components/{runtime_type} endpoint with local as the runtime_type, and no warning message is shown in the logs. A new test is added to cover this case as well.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Jul 28, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but would it be possible to add a handlers test that used local (and reproduces the problem prior to this fix)? If that turns out to be a hassle, I'm okay moving forward, but I think it would be good to have in case we make changes later that wind up side-affecting this PR.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test - this LGTM.

@akchinSTC akchinSTC merged commit 6959117 into elyra-ai:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warnings in pipeline endpoints should be addressed
3 participants