-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for how canvas handles icon size #2914
Conversation
Canvas wraps svgs in a svg tag that sets the icon width and height. This doesn't work if the svg already sets those values. So I removed the width and height from the icons on the backend to compensate. The new values are in line with the JupyterLab icons.
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
icons lgtm now
Canvas wraps svgs in a svg tag that sets the icon width and height. This doesn't work if the svg already sets those values. So I removed the width and height from the icons on the backend to compensate. The new values are in line with the JupyterLab icons.
Canvas wraps svgs in a second svg tag that sets the icon width and height.
This doesn't work if the svg already sets those values, so I removed the width and height from the icons on the backend to compensate.
The new values are in line with the icons provided by JupyterLab.
Developer's Certificate of Origin 1.1