Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for how canvas handles icon size #2914

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

ajbozarth
Copy link
Member

Canvas wraps svgs in a second svg tag that sets the icon width and height.
This doesn't work if the svg already sets those values, so I removed the width and height from the icons on the backend to compensate.
The new values are in line with the icons provided by JupyterLab.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Canvas wraps svgs in a svg tag that sets the icon width and height.
This doesn't work if the svg already sets those values. So I
removed the width and height from the icons on the backend to
compensate. The new values are in line with the JupyterLab icons.
@ajbozarth ajbozarth added the kind:bug Something isn't working label Aug 31, 2022
@ajbozarth ajbozarth added this to the 3.11.1 milestone Aug 31, 2022
@ajbozarth ajbozarth self-assigned this Aug 31, 2022
@elyra-bot
Copy link

elyra-bot bot commented Aug 31, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@akchinSTC akchinSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately still seeing the issue, it only affects the python icon, everything else is fine
image

Copy link
Member

@akchinSTC akchinSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensure browser cache is cleared for localhost or where-ever elyra is being hosted
image

Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icons lgtm now

@ptitzler ptitzler added the component:pipeline-editor pipeline editor label Sep 1, 2022
@akchinSTC akchinSTC merged commit 46a6335 into elyra-ai:main Sep 1, 2022
@ajbozarth ajbozarth deleted the icon_size branch September 1, 2022 17:51
akchinSTC pushed a commit that referenced this pull request Sep 1, 2022
Canvas wraps svgs in a svg tag that sets the icon width and height.
This doesn't work if the svg already sets those values. So I
removed the width and height from the icons on the backend to
compensate. The new values are in line with the JupyterLab icons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:pipeline-editor pipeline editor kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants