Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap jupyter-events to <0.5.0 due to jsonschema version conflict #3055

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

akchinSTC
Copy link
Member

@akchinSTC akchinSTC commented Dec 12, 2022

Signed-off-by: Alan Chin akchin@us.ibm.com

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
jupyter-events 0.5.0 requires jsonschema[format-nongpl]>=4.3.0, but you have jsonschema 3.2.0 which is incompatible.

Need to cap jupyter-events due to 0.5.0 requiring jsonschema > 4.x, which causes conflicts with KFP dependency

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Alan Chin <akchin@us.ibm.com>
@akchinSTC akchinSTC added the component:build build and build related issues(dependencies and docker) label Dec 12, 2022
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ptitzler ptitzler added this to the 3.14.0 milestone Dec 13, 2022
@akchinSTC akchinSTC merged commit bd6a422 into elyra-ai:main Dec 13, 2022
@pasky
Copy link

pasky commented Dec 25, 2022

Did this actually help you resolve the issue?

jupyter-events <0.5.0 installs because it doesn't have a version floor for jsonschema in its dependencies, but it (or jupyter lab as a whole) actually doesn't run with jsonschema<4 anyway - at least for me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:build build and build related issues(dependencies and docker)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants