Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix write_error function implementation in handlers #3080

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

akchinSTC
Copy link
Member

@akchinSTC akchinSTC commented Jan 18, 2023

Signed-off-by: Alan Chin akchin@us.ibm.com

Fixes select changes that went into #3038, causing issues with the Mixins in our handlers.
Check and suppress CodeQL warnings if they pop up.

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@akchinSTC akchinSTC added this to the 3.14.2 milestone Jan 18, 2023
@akchinSTC akchinSTC added the kind:bug Something isn't working label Jan 18, 2023
@ptitzler ptitzler linked an issue Jan 18, 2023 that may be closed by this pull request
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Confirmed that write_error is no longer invoked anywhere. Also verified that the related issues reported in #3077 and #3066 are no longer occurring.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akchinSTC - to address the the code QL issues, I think your previous version was close.

Rather than have the delegation be HTTPErrorMixin().write_error(params), it only needed to be HTTPErrorMixin.write_error(params). That is, it was the instance creation that was the cause of the issue.

Rather than dismiss all of the alerts (and hope they don't return), I guess I'm more inclined to try the recommended fix of pinning the write_error() to HTTPErrorMixin.

Signed-off-by: Alan Chin <akchin@us.ibm.com>
Signed-off-by: Alan Chin <akchin@us.ibm.com>
@akchinSTC akchinSTC changed the title Revert explicit write_error function implementation in handlers Fix write_error function implementation in handlers Jan 18, 2023
@akchinSTC akchinSTC merged commit 077aebf into elyra-ai:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPE: pipeline export fails if the output file already exists
3 participants