Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to Python 3.7 #3101

Merged
merged 4 commits into from
Feb 7, 2023
Merged

Remove references to Python 3.7 #3101

merged 4 commits into from
Feb 7, 2023

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Feb 6, 2023

This PR updates references to Python v3.7, which is no longer supported by Jupyterlab 4.0. To locate impacted files I've scanned the repository for 3.7 and 37.

Need input on https://github.com/ptitzler/elyra/blob/rip-py7/pyproject.toml#L23 (What's supposed to be the new floor?)

Signed-off-by: Patrick Titzler ptitzler@us.ibm.com

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
@ptitzler ptitzler added component:build build and build related issues(dependencies and docker) status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. labels Feb 6, 2023
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
@kevin-bates
Copy link
Member

Need input on https://github.com/ptitzler/elyra/blob/rip-py7/pyproject.toml#L23 (What's supposed to be the new floor?)

There's no need to increase the floor as newer versions of Python work fine. That comment was there to prevent its increase so long as Python 3.7 was supported - otherwise 3.7 installations would break. Since this is removing its support, we should remove the comment.

Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow - we really had to introduce lots of one-offs for 3.7 - this winds up being a nice cleanup - thanks.

Just a couple nits on tightening up the classifiers.

etc/templates/setup.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
@ptitzler ptitzler removed the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Feb 7, 2023
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @ptitzler.

@akchinSTC akchinSTC merged commit 8e863cc into elyra-ai:main Feb 7, 2023
@akchinSTC akchinSTC linked an issue Feb 21, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:build build and build related issues(dependencies and docker)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for Python 3.7
4 participants