Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine which kernel to use prior to notebook execution #3135

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

ptitzler
Copy link
Member

Fixes #3134
See issue for details.

What changes were proposed in this pull request?

  • Add and invoke new method find_best_kernel to replicate the behavior of the bootstrapper implementation for Kubeflow Pipelines.

How was this pull request tested?

  • Added bootstrapper tests, which were already used to test the Kubeflow Pipelines bootstrapper

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
@ptitzler ptitzler added kind:bug Something isn't working platform: pipeline-Airflow Related to usage of Apache Airflow as pipeline runtime labels Mar 22, 2023
@ptitzler ptitzler added this to the 3.15.0 milestone Mar 22, 2023
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - thank you for adding the tests as well!

@ptitzler
Copy link
Member Author

Integration test failures are unrelated to the changes. They started to show up in yesterday's scheduled run.

@ptitzler ptitzler merged commit 84aadfb into elyra-ai:main Mar 23, 2023
@ptitzler ptitzler deleted the airflow-bootstrapper-kernel branch March 23, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Something isn't working platform: pipeline-Airflow Related to usage of Apache Airflow as pipeline runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic components on Airflow fail if the notebook's kernel name is not found
3 participants