Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard peripheral example with builder #227

Merged
merged 7 commits into from
Feb 11, 2024

Conversation

dzervas
Copy link
Contributor

@dzervas dzervas commented Feb 4, 2024

No description provided.

@alexmoon
Copy link
Contributor

alexmoon commented Feb 5, 2024

Thanks! nrf-softdevice now supports rustc stable, so we can't use any nightly features. Is it possible to rework your hid macro to use macro_rules! instead?

Signed-off-by: Dimitris Zervas <dzervas@dzervas.gr>
@dzervas
Copy link
Contributor Author

dzervas commented Feb 9, 2024

oh right! macro_rules!, I completely forgot about it!

@alexmoon
Copy link
Contributor

alexmoon commented Feb 9, 2024

Thanks! Can you also revert the formatting changes to Cargo.toml?

@alexmoon
Copy link
Contributor

I think you still need your [[bin]] section? I was just asking you to revert the formatting changes that were unrelated to this PR.

@dzervas
Copy link
Contributor Author

dzervas commented Feb 10, 2024

oops, reverted a bit too much!

@alexmoon alexmoon added this pull request to the merge queue Feb 11, 2024
Merged via the queue into embassy-rs:master with commit da232c8 Feb 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants