Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug: "timeout_millis" option doesn't work as expected #51

Merged
merged 2 commits into from
Aug 1, 2018
Merged

Fix bug: "timeout_millis" option doesn't work as expected #51

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b40d96
Fix bug: `timeout_millis` option doesn't work as expected
sakama Aug 1, 2018
58215b0
Use timeout_millis for "org.eclipse.jetty.client.api.Request.timeout(…
sakama Aug 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/org/embulk/output/elasticsearch/ElasticsearchHttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ private JsonNode parseJson(final String json) throws DataException
}
}

private Jetty92RetryHelper createRetryHelper(PluginTask task)
private Jetty92RetryHelper createRetryHelper(final PluginTask task)
{
return new Jetty92RetryHelper(
task.getMaximumRetries(),
Expand All @@ -402,6 +402,7 @@ private Jetty92RetryHelper createRetryHelper(PluginTask task)
public org.eclipse.jetty.client.HttpClient createAndStart()
{
org.eclipse.jetty.client.HttpClient client = new org.eclipse.jetty.client.HttpClient(new SslContextFactory());
client.setConnectTimeout(task.getTimeoutMills());
try {
client.start();
return client;
Expand Down