Use XDocument

[SimonCropp]

re this VerifyTests/Verify#585

the reason Verify doesnt have a VerifyXml is that i assumed it was sufficient to have support for XDocument.

XDocument is the current recommended way to build up an xml string.

In this PR i changed ExportFull over to returning a XDocument. That can then be passed directly to Verifier.Verify.

side note Verify also has support for XmlNode, XmlDocument, and XElement.

[SimonCropp]

let me know if u want the rest converted

[emilybache]

Thankyou for telling me about Verify features for xml that I didn't know about!

This repo is an exercise and it's designed to look like legacy code. Returning a String is totally deliberate. You've changed the starting position to return an XDocument and that's basically part of the exercise that I want students to do. So no, I don't want this change in the XmlExporter class.

The first part of the exercise is to add approval tests, and the second part is to refactor and for example change it to use XDocument. On the 'with_tests' branch i have a positioned the code between part 1 and part 2 of the exercise.

I think what I understand from you is that you don't want to add a 'VerifyXml' to Verifier. Perhaps we could discuss that further in the other github issue.

[emilybache]

Thanks again for your contribution. I updated the code slightly differently now, to preserve the starting position in XmlExporter. What do you think?