Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a $ to the demo app to demonstrate the issues with it #14

Merged
merged 1 commit into from
Aug 12, 2021
Merged

add a $ to the demo app to demonstrate the issues with it #14

merged 1 commit into from
Aug 12, 2021

Conversation

nickschot
Copy link
Contributor

No description provided.

@nickschot nickschot requested a review from mansona July 29, 2021 14:40
mansona
mansona approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! looks good

I can see the issue now very clearly in the demo 🙈

@mansona mansona merged commit 2d7ee85 into master Aug 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-demo branch August 12, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickschot @mansona