Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling default failure predicates. #997

Merged
merged 7 commits into from
Jun 12, 2023

Conversation

mergeconflict
Copy link
Member

@mergeconflict mergeconflict commented Jun 7, 2023

Works on #826

Signed-off-by: Dan Rosen <mergeconflict@google.com>
Copy link
Collaborator

@mum4k mum4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the CI failed, because README needs to be regenerated.

Could you try running this locally and uploading the commit?

tools/update_cli_readme_documentation.sh --mode fix

Additionally we should add both a unit test and an e2e test for the new feature. The unit test should live here and the integration test probably here.

Signed-off-by: Dan Rosen <mergeconflict@google.com>
@mergeconflict
Copy link
Member Author

Could you try running this locally and uploading the commit?

tools/update_cli_readme_documentation.sh --mode fix

Done, thanks!

Additionally we should add both a unit test and an e2e test for the new feature. The unit test should live here and the integration test probably here.

I've added a unit test. I agree an e2e test would make sense, but I'm having some trouble constructing one, maybe you have some advice... My issue is that I can't find a way to configure NH test server to send error responses, which is necessary to verify that there aren't any failure predicates. Any suggestion?

@mum4k
Copy link
Collaborator

mum4k commented Jun 7, 2023

Without looking closer - could we achieve the same by pointing Nighthawk to a port the test server isn't listening on?

Signed-off-by: Dan Rosen <mergeconflict@google.com>
Signed-off-by: Dan Rosen <mergeconflict@google.com>
@mergeconflict mergeconflict requested a review from mum4k June 8, 2023 19:32
Copy link
Collaborator

@mum4k mum4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, glad this approach worked out. I have two minor requests aiming to make the integration test case more understandable.

test/integration/test_integration_basics.py Outdated Show resolved Hide resolved
test/integration/test_integration_basics.py Show resolved Hide resolved
Signed-off-by: Dan Rosen <mergeconflict@google.com>
@mergeconflict mergeconflict requested a review from mum4k June 9, 2023 19:34
Signed-off-by: Dan Rosen <mergeconflict@google.com>
Copy link
Collaborator

@mum4k mum4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for moving the code to the utility library.

Looks like the CI is failing due to formatting of Python files, could you execute ci/do_ci.sh fix_format and see if that helps?

@mum4k mum4k self-assigned this Jun 12, 2023
Signed-off-by: Dan Rosen <mergeconflict@google.com>
@mergeconflict mergeconflict requested a review from mum4k June 12, 2023 16:25
Copy link
Collaborator

@mum4k mum4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mergeconflict !

@mum4k mum4k merged commit 8da4c81 into envoyproxy:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants