Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove write on save #32

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Remove write on save #32

merged 2 commits into from
Oct 12, 2022

Conversation

vihu
Copy link
Contributor

@vihu vihu commented Oct 12, 2022

Fix #30

New behavior:

2022-10-12.10-03-03.mp4

epwalsh
epwalsh approved these changes Oct 12, 2022
View reviewed changes
Copy link
Owner

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@epwalsh
Copy link
Owner

epwalsh commented Oct 12, 2022

Can you just add a CHANGELOG entry?

@vihu
Copy link
Contributor Author

vihu commented Oct 12, 2022

Can you just add a CHANGELOG entry?

Updated in fcb9dae. Assumed it goes in the "Unreleased" section.

@epwalsh epwalsh merged commit d4069f5 into epwalsh:main Oct 12, 2022
@vihu vihu deleted the rg/remove-write-on-save branch October 12, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epwalsh epwalsh epwalsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected current buffer change on new note
2 participants
@vihu @epwalsh