Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade to vim.islist without errors #598

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

JojoMakesGames
Copy link
Contributor

@JojoMakesGames JojoMakesGames commented May 25, 2024

Was getting an error when starting up neovim sourced from this plugin:
image

Fix was to follow the deprecation style in the same file:

compat.flatten = function(t)
  if vim.fn.has "nvim-0.11" == 1 then
    return vim.iter(t):flatten():totable()
  else
    return vim.tbl_flatten(t)
  end
end

This removes the error. All tests pass since functionality is the same.

Chose not to add to changelog since this seemed to fit with the line:
"- Add compatibility for NVIM 0.11"

@JojoMakesGames
Copy link
Contributor Author

Let me know if I need to add to the changelog in this case. It felt redundant but I see that the workflow requires it for a successful PR

Copy link
Owner

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JojoMakesGames!

@epwalsh epwalsh merged commit d808307 into epwalsh:main May 31, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants