Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add cleanups in device,vlan and ports e2e tests to stabilise the CI pipeline #405

Merged
merged 5 commits into from
Dec 18, 2023
Merged

fix: Add cleanups in device,vlan and ports e2e tests to stabilise the CI pipeline #405

merged 5 commits into from
Dec 18, 2023

Conversation

aayushrangwala
Copy link
Contributor

@aayushrangwala aayushrangwala commented Dec 11, 2023 •
edited by displague
Loading

fixes #343
fixes #387

@aayushrangwala aayushrangwala requested a deployment to external December 13, 2023 16:56 — with GitHub Actions Abandoned
@aayushrangwala aayushrangwala requested a deployment to external December 13, 2023 17:18 — with GitHub Actions Abandoned
ctreatma
ctreatma reviewed Dec 13, 2023
View reviewed changes
test/helper/helper.go Outdated Show resolved Hide resolved
ctreatma
ctreatma reviewed Dec 13, 2023
View reviewed changes
test/helper/helper.go Outdated Show resolved Hide resolved
@aayushrangwala aayushrangwala requested a deployment to external December 15, 2023 17:53 — with GitHub Actions Abandoned
@aayushrangwala aayushrangwala requested a deployment to external December 18, 2023 16:13 — with GitHub Actions Abandoned
displague
displague reviewed Dec 18, 2023
View reviewed changes
test/helper/helper.go Outdated Show resolved Hide resolved
@aayushrangwala
fix: Add cleanups in device,vlan and ports e2e tests to stabilise the…
323335b 
… CI pipeline
@aayushrangwala
fix: helper file
c75c342 
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
@aayushrangwala
t.error to t.fatal
f6b390e 
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
@aayushrangwala
fix: project suffix
fbcfafa 
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
@aayushrangwala
update random function generator
149fcf8 
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
displague
displague approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@displague displague left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving contingent on tests (which seem to be stuck)

@displague
Copy link
Member

E2E test failures were about availability and the ability to access resources that were no longer available. Nothing tied to these changes.

@displague displague merged commit 4b0a89e into equinix:main Dec 18, 2023
8 of 9 checks passed
@displague
Copy link
Member

displague commented Dec 18, 2023 •
edited
Loading

I was anxious to capture the testing improvements and refactors and my last comment (and merge) was oblivious to the premise of this PR, to address the device-related E2E test failures. We still have some and I'll reopen the tracking issue to say as much.

@ctreatma ctreatma mentioned this pull request Dec 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctreatma ctreatma ctreatma left review comments

@displague displague displague approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E tests (run in CI) are not cleaning up server and project artifacts TestPorts_VLANs E2E test failed
3 participants
@aayushrangwala @displague @ctreatma