Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

Fix gateway and vc delete waiting #238

Merged
merged 4 commits into from
Jul 5, 2022
Merged

Conversation

ocobles
Copy link
Contributor

@ocobles ocobles commented Jul 1, 2022

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #238 (3f9fde6) into main (105e9c0) will increase coverage by 8.01%.
The diff coverage is 89.28%.

@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   69.06%   77.08%   +8.01%     
==========================================
  Files          51       51              
  Lines        6891     6946      +55     
==========================================
+ Hits         4759     5354     +595     
+ Misses       1957     1359     -598     
- Partials      175      233      +58     
Impacted Files Coverage Δ
metal/resource_metal_virtual_circuit.go 76.45% <66.66%> (-0.83%) ⬇️
metal/resource_metal_gateway.go 83.82% <84.00%> (+0.03%) ⬆️
metal/datasource_metal_virtual_circuit.go 95.28% <96.00%> (+27.33%) ⬆️
metal/config.go 50.94% <0.00%> (-7.55%) ⬇️
metal/resource_metal_reserved_ip_block.go 82.67% <0.00%> (+2.09%) ⬆️
metal/resource_metal_spot_market_request.go 57.85% <0.00%> (+2.29%) ⬆️
metal/helpers_device.go 82.63% <0.00%> (+2.63%) ⬆️
metal/datasource_metal_spot_market_request.go 89.69% <0.00%> (+4.12%) ⬆️
metal/resource_metal_device.go 59.15% <0.00%> (+5.16%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbda636...3f9fde6. Read the comment docs.

ocobles and others added 4 commits July 5, 2022 13:47
Co-authored-by: Marques Johansson <mjohansson@equinix.com>

Signed-off-by: Óscar Cobles <68897552+ocobleseqx@users.noreply.github.com>
@ocobles ocobles force-pushed the fix-gateway-and-vc-delete-waiting branch from 68d3762 to 50b3f36 Compare July 5, 2022 18:49
@displague displague merged commit 4cc4b84 into main Jul 5, 2022
@displague displague deleted the fix-gateway-and-vc-delete-waiting branch July 5, 2022 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants