Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-client: distinguish no tls or tls: insecure skip verify #309

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

sfwn
Copy link
Member

@sfwn sfwn commented Dec 13, 2023

What this PR does / why we need it:

grpc-client: distinguish no tls or tls: insecure skip verify

usage:

notls (default):

grpc-client:
  addr: localhost:8082

insecure_skip_verify: true

grpc-client:
  addr: ai-proxy-grpc.erda.cloud:443
  tls:
    insecure_skip_verify: true

Specified Reviewers:

/assign @chengjoey

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #309 (cdc977b) into master (3a92b81) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #309   +/-   ##
=======================================
  Coverage   35.18%   35.18%           
=======================================
  Files         106      106           
  Lines        5949     5949           
=======================================
  Hits         2093     2093           
  Misses       3698     3698           
  Partials      158      158           

@sfwn sfwn merged commit 67b1657 into erda-project:master Dec 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants