Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: required items field is not marked #746

Conversation

hujiahao-hjh
Copy link
Contributor

What this PR does / why we need it:

fix required items field is not marked.

Does this PR introduce a user interface change?

✅ Yes(screenshot is required)
image
->
image

ChangeLog

Language Changelog
🇺🇸 English Fixed a bug where required items for project collaboration did not have required tags.
🇨🇳 中文 修复了项目协同的必填项没有必填标记的bug。

Which versions should be patched?

Which issue(s) this PR fixes:

Fixes # required items field is not marked

@hujiahao-hjh hujiahao-hjh force-pushed the hotfix/custom-item-field-require-sign-bug branch from 6c2bd59 to dfa7d42 Compare July 26, 2021 09:49
McDaddy
McDaddy previously approved these changes Jul 26, 2021
@hujiahao-hjh hujiahao-hjh force-pushed the hotfix/custom-item-field-require-sign-bug branch from 164c307 to 4f6d996 Compare July 26, 2021 10:40
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #746 (4f6d996) into master (410709e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   81.09%   81.09%           
=======================================
  Files         113      113           
  Lines        6713     6714    +1     
  Branches     1848     1849    +1     
=======================================
+ Hits         5444     5445    +1     
  Misses       1234     1234           
  Partials       35       35           
Impacted Files Coverage Δ
shell/app/common/components/edit-field.tsx 99.13% <100.00%> (+<0.01%) ⬆️

@McDaddy McDaddy merged commit 9cf6d29 into erda-project:master Jul 26, 2021
@daskyrk daskyrk added the bugfix Used in pr label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Used in pr
Development

Successfully merging this pull request may close these issues.

3 participants