Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmp): group rule change to required #752

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

wuhuiluo
Copy link
Contributor

@wuhuiluo wuhuiluo commented Jul 27, 2021

What this PR does / why we need it:

feat(cmp): group rule change to required

Does this PR introduce a user interface change?

❎ No

ChangeLog

Language Changelog
🇺🇸 English When creating a custom alarm rule, change the grouping rule to a required option
🇨🇳 中文 创建自定义告警规则的时候把分组规则改成必选项

Which versions should be patched?

Which issue(s) this PR fixes:

Fixes #

@wuhuiluo wuhuiluo added the cmp Cloud Management platform label Jul 27, 2021
@daskyrk
Copy link
Contributor

daskyrk commented Jul 27, 2021

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Jul 27, 2021
erda-bot
erda-bot previously approved these changes Jul 27, 2021
@Zero-Rock
Copy link
Contributor

/approve

@erda-bot erda-bot merged commit aee072d into erda-project:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot cmp Cloud Management platform
Development

Successfully merging this pull request may close these issues.

5 participants