Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the bug that the log cannot be downloaded using the default duration #842

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

Zero-Rock
Copy link
Contributor

What this PR does / why we need it:

fix the bug that the log cannot be downloaded using the default duration

Does this PR introduce a user interface change?

❎ No

ChangeLog

Language Changelog
🇺🇸 English fix the bug that the log cannot be downloaded using the default duration
🇨🇳 中文 修复使用默认时长无法下载日志的bug

Does this PR need be patched to older version?

✅ Yes(version is required)

release/1.2

Which issue(s) this PR fixes:

Fixes #

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #842 (85cb39c) into master (d02b6ea) will increase coverage by 0.30%.
The diff coverage is 94.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
+ Coverage   81.04%   81.35%   +0.30%     
==========================================
  Files         113      113              
  Lines        6722     6737      +15     
  Branches     1713     1718       +5     
==========================================
+ Hits         5448     5481      +33     
+ Misses       1241     1222      -19     
- Partials       33       34       +1     
Impacted Files Coverage Δ
...l/app/common/components/log/download-log-modal.tsx 97.36% <ø> (ø)
shell/app/common/components/contractive-filter.tsx 6.48% <50.00%> (+0.35%) ⬆️
shell/app/common/components/add-member-modal.tsx 98.27% <100.00%> (ø)
shell/app/common/components/back-to-top.tsx 96.66% <100.00%> (ø)
shell/app/common/components/confirm-delete.tsx 100.00% <100.00%> (ø)
shell/app/common/components/details-panel.tsx 100.00% <100.00%> (ø)
shell/app/common/components/dropdown-select.tsx 100.00% <100.00%> (ø)
...hell/app/common/components/erda-icon/erda-icon.tsx 100.00% <100.00%> (+10.00%) ⬆️
shell/app/common/components/image-upload.tsx 100.00% <100.00%> (ø)
shell/app/common/components/load-more-selector.tsx 54.83% <100.00%> (+0.16%) ⬆️
... and 10 more

@McDaddy McDaddy merged commit 5de8a35 into erda-project:master Aug 4, 2021
@McDaddy
Copy link
Contributor

McDaddy commented Aug 4, 2021

/cherry-pick release/1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants