Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trace debug add params style bug #857

Conversation

hujiahao-hjh
Copy link
Contributor

What this PR does / why we need it:

fix trace debug add params style bug.

Does this PR introduce a user interface change?

✅ Yes(screenshot is required)
image
->
image

ChangeLog

Language Changelog
🇺🇸 English In the trace-debug, the text prompt that the form verification fails when adding parameters is not displayed completely.
🇨🇳 中文 在链路调试中,添加参数时表单校验不通过的文字提示显示不完全。

Does this PR need be patched to older version?

✅ Yes(version is required)
release/1.2

Which issue(s) this PR fixes:

Fixes # trace debug add params style bug

@hujiahao-hjh hujiahao-hjh added the bugfix Used in pr label Aug 5, 2021
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #857 (db32ac1) into master (5de8a35) will increase coverage by 1.74%.
The diff coverage is n/a.

❗ Current head db32ac1 differs from pull request most recent head 82f3898. Consider uploading reports for the commit 82f3898 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
+ Coverage   81.35%   83.10%   +1.74%     
==========================================
  Files         113      112       -1     
  Lines        6737     6729       -8     
  Branches     1718     1714       -4     
==========================================
+ Hits         5481     5592     +111     
+ Misses       1222     1103     -119     
  Partials       34       34              
Impacted Files Coverage Δ
shell/app/common/components/key-value-table.tsx 96.15% <ø> (ø)
shell/app/common/index.ts 100.00% <0.00%> (ø)
shell/app/common/components/img-holder.tsx 100.00% <0.00%> (ø)
shell/app/common/components/color-label.tsx
...ll/app/common/components/markdown-editor/index.tsx 93.58% <0.00%> (+0.81%) ⬆️
shell/app/common/components/render-formItem.tsx 67.69% <0.00%> (+2.30%) ⬆️
shell/app/common/components/operate-btn.tsx 91.17% <0.00%> (+5.88%) ⬆️
shell/app/common/components/form-modal.tsx 94.44% <0.00%> (+17.59%) ⬆️
shell/app/common/components/contractive-filter.tsx 37.40% <0.00%> (+30.91%) ⬆️
shell/app/common/components/tags-row.tsx 97.56% <0.00%> (+31.70%) ⬆️

@daskyrk
Copy link
Contributor

daskyrk commented Aug 9, 2021

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Aug 9, 2021
@erda-bot erda-bot merged commit e0ae145 into erda-project:master Aug 9, 2021
@daskyrk
Copy link
Contributor

daskyrk commented Aug 9, 2021

/cherry-pick release/1.2

erda-bot pushed a commit to erda-bot/erda-ui that referenced this pull request Aug 9, 2021
* fix: trace debug add params style bug

* fix: use official interaction

* fix: use official interaction

* fix: code optimization
daskyrk pushed a commit that referenced this pull request Aug 9, 2021
* fix: trace debug add params style bug

* fix: use official interaction

* fix: use official interaction

* fix: code optimization

Co-authored-by: hujiahao-hjh <82502479+hujiahao-hjh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot bugfix Used in pr
Development

Successfully merging this pull request may close these issues.

3 participants