Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pipeline event url #1189

Merged

Conversation

pipipipipi43
Copy link
Contributor

What type of this PR

Add one of the following kinds:

kind feature

What this PR does / why we need it:

You can directly click on the url in the Dingding group to enter the pipeline page

Which issue(s) this PR fixes:

https://terminus-org.app.terminus.io/erda/dop/projects/387/issues/requirement?id=65866&issueFilter__urlQuery=eyJzdGF0ZUJlbG9uZ3MiOlsiT1BFTiIsIldPUktJTkciXX0%3D&issueTable__urlQuery=eyJwYWdlTm8iOjEsICJwYWdlU2l6ZSI6MTB9&issueViewGroup__urlQuery=eyJ2YWx1ZSI6InRhYmxlIiwiY2hpbGRyZW5WYWx1ZSI6eyJrYW5iYW4iOiJkZWFkbGluZSJ9fQ%3D%3D&type=requirement

old:

屏幕快照 2021-07-28 下午5 19 50

now:

屏幕快照 2021-07-28 下午5 19 42

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #1189 (f463093) into master (4267747) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1189   +/-   ##
=======================================
  Coverage   11.68%   11.68%           
=======================================
  Files         973      968    -5     
  Lines      100649   100575   -74     
=======================================
- Hits        11761    11757    -4     
+ Misses      87830    87759   -71     
- Partials     1058     1059    +1     
Impacted Files Coverage Δ
pkg/mock/mock.go 25.00% <0.00%> (-4.55%) ⬇️
...ules/openapi/api/apis/admin/admin_notice_create.go
...s/openapi/api/apis/admin/admin_notice_unpublish.go
...ules/openapi/api/apis/admin/admin_notice_delete.go
...ules/openapi/api/apis/admin/admin_notice_update.go
...les/openapi/api/apis/admin/admin_notice_publish.go

pkg/erda-configs/i18n/notify_item.yml Outdated Show resolved Hide resolved
@pipipipipi43 pipipipipi43 force-pushed the feature/add_pipeline_event_url branch from cdb096e to f463093 Compare July 28, 2021 12:40
@sfwn
Copy link
Member

sfwn commented Jul 28, 2021

/approve

@erda-bot erda-bot merged commit 75a759f into erda-project:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants