feature: remove git inner user #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1607 +/- ##
==========================================
+ Coverage 12.64% 13.00% +0.36%
==========================================
Files 1037 1042 +5
Lines 109338 108755 -583
==========================================
+ Hits 13824 14143 +319
+ Misses 93929 93349 -580
+ Partials 1585 1263 -322
|
|
Can you prove how other part (such as pipeline) still work normally after deleting inner user? Given some related pr or flow description or screenshot please. |
sfwn
requested changes
Sep 1, 2021
| @@ -224,7 +222,6 @@ func doAuth(c *webcontext.Context, repo *models.Repo, repoName string) { | |||
| return | |||
| } | |||
| c.Set("repository", gitRepository) | |||
| //c.Set("lock", repoLock.Lock) | |||
littlejiancc
force-pushed
the
feature/gittar-innerUser
branch
2 times, most recently
from
e4a4f8f
to
afbb1a3
Compare
littlejiancc
force-pushed
the
feature/gittar-innerUser
branch
from
afbb1a3
to
fe65dc0
Compare
sfwn
approved these changes
Sep 1, 2021
|
/approve |
erda-bot
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
/kind feature
What this PR does / why we need it:
fix: remove git inner user
Which issue(s) this PR fixes:
gittar 删除内置 git_inner_user
Specified Reviewers:
/assign @sfwn
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.