Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/pipeline apitest cost time #2650

Merged
merged 3 commits into from
Nov 2, 2021

Conversation

chengjoey
Copy link
Contributor

What type of this PR

Add one of the following kinds:
/kind bug

What this PR does / why we need it:

use goroutine execute apitest make cost time current

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@chengjoey chengjoey added bug pipeline pipeline service labels Oct 28, 2021
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #2650 (1ef17f8) into master (13539c0) will decrease coverage by 0.07%.
The diff coverage is 22.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2650      +/-   ##
==========================================
- Coverage   16.93%   16.85%   -0.08%     
==========================================
  Files        1279     1284       +5     
  Lines      130253   130977     +724     
==========================================
+ Hits        22055    22075      +20     
- Misses     105797   106499     +702     
- Partials     2401     2403       +2     
Impacted Files Coverage Δ
modules/pipeline/pipengine/reconciler/reconcile.go 0.00% <ø> (ø)
...pipeline/pipengine/reconciler/taskrun/framework.go 0.00% <0.00%> (ø)
...s/pipeline/pipengine/reconciler/taskrun/taskrun.go 0.00% <0.00%> (ø)
...peline/pipengine/reconciler/taskrun/taskop/wait.go 8.51% <19.35%> (ø)
...ngine/actionexecutor/plugins/apitest/logic/meta.go 46.34% <57.14%> (+4.23%) ⬆️
...ine/pipengine/reconciler/taskrun/taskop/prepare.go 0.00% <0.00%> (ø)
... and 5 more

@chengjoey chengjoey force-pushed the fix/pipeline-long-time-wait branch 3 times, most recently from 82170cd to cecc649 Compare November 1, 2021 03:48
@sfwn
Copy link
Member

sfwn commented Nov 2, 2021

add screenshot for your tests.

@chengjoey
Copy link
Contributor Author

add screenshot for your tests.

image

@sfwn
Copy link
Member

sfwn commented Nov 2, 2021

/approve

@erda-bot erda-bot merged commit a7e0350 into erda-project:master Nov 2, 2021
@sfwn
Copy link
Member

sfwn commented Nov 2, 2021

/cherry-pick release/1.4

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Nov 2, 2021
* modify task wait op, listen executor channel

* apitest action don't set task pointers value

* api-test executor define add snyc.map to store running task
erda-bot added a commit that referenced this pull request Nov 2, 2021
* modify task wait op, listen executor channel

* apitest action don't set task pointers value

* api-test executor define add snyc.map to store running task

Co-authored-by: chengjoey <30427474+chengjoey@users.noreply.github.com>
@chengjoey chengjoey deleted the fix/pipeline-long-time-wait branch November 15, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants