-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loop task not reset begintime #2816
Merged
erda-bot
merged 1 commit into
erda-project:master
from
kakj-go:feature/loop-task-not-reset-begintime
Nov 3, 2021
Merged
loop task not reset begintime #2816
erda-bot
merged 1 commit into
erda-project:master
from
kakj-go:feature/loop-task-not-reset-begintime
Nov 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated cherry pick can ONLY be triggered when this PR is MERGED! |
kakj-go
force-pushed
the
feature/loop-task-not-reset-begintime
branch
from
November 3, 2021 06:02
1cc054e
to
88a5abf
Compare
Codecov Report
@@ Coverage Diff @@
## master #2816 +/- ##
==========================================
+ Coverage 16.86% 16.96% +0.10%
==========================================
Files 1284 1285 +1
Lines 130955 131094 +139
==========================================
+ Hits 22080 22245 +165
+ Misses 106589 106552 -37
- Partials 2286 2297 +11
|
kakj-go
force-pushed
the
feature/loop-task-not-reset-begintime
branch
from
November 3, 2021 09:32
88a5abf
to
39dd23f
Compare
sfwn
approved these changes
Nov 3, 2021
/approve |
erda-bot
approved these changes
Nov 3, 2021
/cherry-pick release/1.4 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
/kind bugfix
What this PR does / why we need it:
The start execution time is not reset when the pipeline cyclic task is executed. The result of the reset is that the user cannot know the execution time of the cyclic task
Which issue(s) this PR fixes:
ChangeLog
Need cherry-pick to release versions?
/cherry-pick release/1.4