Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate all message to messageId #482

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

scagood
Copy link
Contributor

@scagood scagood commented Jul 16, 2024

Migrate all message to messageId (for the update to eslint-plugin-eslint-plugin)

(#471)

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bbcfcbf) to head (29130f1).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #482   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        24    -1     
  Lines          649       660   +11     
  Branches       250       246    -4     
=========================================
+ Hits           649       660   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brettz9
Copy link
Member

brettz9 commented Jul 16, 2024

Was this one supposed to be as a draft too?

@scagood scagood marked this pull request as ready for review July 16, 2024 14:39
Copy link
Member

@brettz9 brettz9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like most of the names here (better than the ones I was attempting in my own PR), but just those few mentioned could I think be improved, with the naming being important since they are meant to be accessed even outside the file containing them as in the test files (so the test files can avoid specifying an exact syntax which might be contradicted by a change of the message in the rule file).

rules/always-return.js Outdated Show resolved Hide resolved
rules/prefer-await-to-then.js Outdated Show resolved Hide resolved
rules/valid-params.js Outdated Show resolved Hide resolved
@scagood scagood requested a review from brettz9 July 17, 2024 07:59
Copy link
Member

@brettz9 brettz9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brettz9
Copy link
Member

brettz9 commented Jul 17, 2024

It looks per https://github.com/eslint-community/governance/pull/1/files that collaborators (and not only team members) can do merges (presumably on other-than-their-own PRs), so I'll go ahead and merge.

@brettz9 brettz9 merged commit b0fc13b into eslint-community:main Jul 17, 2024
17 checks passed
@brettz9
Copy link
Member

brettz9 commented Jul 17, 2024

I changed from feat to refactor, as it seems there are no user-facing changes.

Copy link
Contributor

🎉 This PR is included in version 6.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@scagood scagood deleted the messageid branch July 24, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants