Merge pull request #10646 from yingnanzhang666/metrics_db_compaction

fix issue that metric db_compaction_total_duration_milliseconds is always 0
etcd-io · Apr 20, 2019 · 943d688 · 943d688
2 parents 85594ae + c5cb550
commit 943d688
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/mvcc/kvstore_compaction.go b/mvcc/kvstore_compaction.go
@@ -23,7 +23,7 @@ import (
 
 func (s *store) scheduleCompaction(compactMainRev int64, keep map[revision]struct{}) bool {
 	totalStart := time.Now()
-	defer dbCompactionTotalMs.Observe(float64(time.Since(totalStart) / time.Millisecond))
+	defer func() { dbCompactionTotalMs.Observe(float64(time.Since(totalStart) / time.Millisecond)) }()
 	keyCompactions := 0
 	defer func() { dbCompactionKeysCounter.Add(float64(keyCompactions)) }()