Skip to content

Commit

Permalink
backend: add prometheus metric for large snapshot duration.
Browse files Browse the repository at this point in the history
FIXES #7878
  • Loading branch information
fanminshi committed May 6, 2017
1 parent db6f45e commit c01e297
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
2 changes: 2 additions & 0 deletions mvcc/backend/backend.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,13 @@ func (b *backend) Snapshot() Snapshot {
case <-ticker.C:
plog.Warningf("snapshotting is taking more than %v seconds to finish [started at %v]", time.Since(start).Seconds(), start)
case <-stopc:
snapShotDurations.Observe(time.Since(start).Seconds())
return
}
}
}()

time.Sleep(10 * time.Second)
b.batchTx.Commit()

b.mu.RLock()
Expand Down
10 changes: 10 additions & 0 deletions mvcc/backend/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,18 @@ var (
Help: "The latency distributions of commit called by backend.",
Buckets: prometheus.ExponentialBuckets(0.001, 2, 14),
})

snapShotDurations = prometheus.NewHistogram(prometheus.HistogramOpts{
Namespace: "etcd",
Subsystem: "disk",
Name: "backend_snapshot_duration_seconds",
Help: "The latency distributions of Snapshot called by backend.",
// 1 second -> 1024 seconds
Buckets: prometheus.ExponentialBuckets(1, 2, 10),
})
)

func init() {
prometheus.MustRegister(commitDurations)
prometheus.MustRegister(snapShotDurations)
}

0 comments on commit c01e297

Please sign in to comment.