Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: resolve shellcheck errors. #10216

Merged
merged 1 commit into from
Oct 26, 2018
Merged

*: resolve shellcheck errors. #10216

merged 1 commit into from
Oct 26, 2018

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Oct 25, 2018

Shellcheck v0.5.0 was released in May. This PR squelches a few errors related to SC2230 which are now reported with the latest shellcheck version.

'shellcheck' started at Fri Oct 26 07:26:01 EDT 2018
shellcheck checking failed:
build:18:5: note: which is non-standard. Use builtin 'command -v' instead. [SC2230]
test:237:7: note: which is non-standard. Use builtin 'command -v' instead. [SC2230]
[...]

ref: SC2230

@hexfusion hexfusion changed the title *: resolve shellcheck, which is non-standard errors. *: resolve shellcheck errors. Oct 25, 2018
@codecov-io
Copy link

codecov-io commented Oct 26, 2018

Codecov Report

Merging #10216 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10216      +/-   ##
==========================================
+ Coverage   71.67%   71.86%   +0.18%     
==========================================
  Files         390      390              
  Lines       36351    36351              
==========================================
+ Hits        26054    26122      +68     
+ Misses       8484     8423      -61     
+ Partials     1813     1806       -7
Impacted Files Coverage Δ
proxy/grpcproxy/watcher.go 89.79% <0%> (-4.09%) ⬇️
etcdserver/api/v3rpc/watch.go 82.35% <0%> (-1.64%) ⬇️
clientv3/op.go 73.47% <0%> (-0.87%) ⬇️
etcdserver/v3_server.go 79.17% <0%> (-0.46%) ⬇️
clientv3/leasing/kv.go 90.03% <0%> (-0.34%) ⬇️
clientv3/balancer/grpc1.7-health.go 59.01% <0%> (-0.3%) ⬇️
mvcc/watchable_store.go 84.21% <0%> (ø) ⬆️
etcdserver/server.go 74.73% <0%> (+0.21%) ⬆️
etcdserver/api/rafthttp/stream.go 79.82% <0%> (+0.42%) ⬆️
clientv3/snapshot/v3_snapshot.go 66.26% <0%> (+0.8%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 798955d...78d0114. Read the comment docs.

@mitake
Copy link
Contributor

mitake commented Oct 26, 2018

LGTM

@gyuho
Copy link
Contributor

gyuho commented Oct 26, 2018

/lgtm

@gyuho-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyuho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gyuho gyuho merged commit 5837632 into etcd-io:master Oct 26, 2018
@hexfusion hexfusion deleted the shellcheck branch October 26, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants