add remove peer #134
Merged
add remove peer #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: tests |
|
|
||
| // The name of the remove command in the log | ||
| func (c *RemoveCommand) CommandName() string { | ||
| return "etcd:remove" |
There was a problem hiding this comment.
can you use the commandName func?
There was a problem hiding this comment.
@philips Sure. will change.
|
lgtm after cleaning up the function signature on getMachines and some of the comments. |
|
lgtm, thanks for cleaning that up. |
| @@ -140,18 +142,25 @@ func (c *JoinCommand) CommandName() string { | |||
| // Join a server to the cluster | |||
| func (c *JoinCommand) Apply(raftServer *raft.Server) (interface{}, error) { | |||
|
|
|||
| if c.Name == r.Name() { | |||
There was a problem hiding this comment.
could you write a comment explaining this, I know why this works but not everyone reading the code will.
|
lgtm besides the error message. |
tjungblu
pushed a commit
to tjungblu/etcd
that referenced
this pull request
Sep 5, 2022
…nshift-4.12-ose-etcd Updating ose-etcd images to be consistent with ART
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.