tests: Add triggering random go failpoints to linearizability tests #14687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serathius
force-pushed
the
random-failpoint
branch
3 times, most recently
from
316baa8
to
37b5ddc
Compare
Codecov Report
@@ Coverage Diff @@
## main #14687 +/- ##
==========================================
+ Coverage 75.44% 75.52% +0.07%
==========================================
Files 457 457
Lines 37299 37299
==========================================
+ Hits 28141 28169 +28
+ Misses 7382 7361 -21
+ Partials 1776 1769 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ahrtr
reviewed
Nov 4, 2022
ahrtr
reviewed
Nov 5, 2022
| @@ -130,7 +130,7 @@ func triggerFailpoints(ctx context.Context, clus *e2e.EtcdProcessCluster, config | |||
| for successes < config.count && failures < config.count { | |||
| err = config.failpoint.Trigger(ctx, clus) | |||
| if err != nil { | |||
| fmt.Printf("Failed to trigger failpoint %q, err: %v\n", config.failpoint.Name(), err) | |||
| t.Logf("Failed to trigger failpoint %q, err: %v\n", config.failpoint.Name(), err) | |||
There was a problem hiding this comment.
You need to pass t *testing.T to the function.
serathius
force-pushed
the
random-failpoint
branch
from
8dd68c2
to
bc848d5
Compare
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius
force-pushed
the
random-failpoint
branch
from
bc848d5
to
219278b
Compare
|
ping @ahrtr |
This was referenced Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.