Lease support for linearizability tests : address review feedback #15093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack. Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
|
This PR addresses some of the feedback from #15080.
|
Codecov Report
@@ Coverage Diff @@
## main #15093 +/- ##
==========================================
- Coverage 74.73% 74.62% -0.12%
==========================================
Files 415 415
Lines 34341 34341
==========================================
- Hits 25665 25627 -38
- Misses 7046 7084 +38
Partials 1630 1630
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ahrtr
approved these changes
Jan 13, 2023
| state.KeyLeases[op.Key] = op.LeaseID | ||
| state.Leases[op.LeaseID].Keys[op.Key] = leased | ||
| } | ||
| //nop here since lease wont be there |
There was a problem hiding this comment.
We already support multiple operations, so in theory it's possible that LeaseGrant happens before PutWithLease. But current implementation doesn't support standalone LeaseGrant, which is executed along each PutWithLease, so it's OK for now.
serathius
approved these changes
Jan 13, 2023
This was referenced Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lease support for linearizability tests : address review feedback
Signed-off-by: Geeta Gharpure geetagh@amazon.com